Support for custom procfs path using ENV variable #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecki
reviewed
Aug 29, 2024
| @@ -2070,6 +2071,11 @@ int main | |||
| #endif | |||
| getroute_init(); /* Set up AF routing support */ | |||
|
|
|||
| path_proc = getenv("PATH_PROC"); | |||
There was a problem hiding this comment.
is that some kind of convention standard env for this? If its net tools specific, maybe have a NETTOOLS_PROCPATH instead?
|
sorry for being late to the party. Did you see my comment about the variabnle name? I rebased your change, feel free to squash and force push it instead before i can apply it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #12 .
Setting the environment variable PATH_PROC to the path of the procfs will allow netstat fill in the process/pid data using PATH_PROC value