Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test for bluechi-is-online system --wait #1031

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

DanaOrr
Copy link
Contributor

@DanaOrr DanaOrr commented Jan 26, 2025

Adding integration test for bluechi-is-online system --wait with five tests:

  1. Start node and two agents, keep it running and verify system --wait returns 0 immediately.
  2. Stop agent-one, keep agent-two running and verify system --wait returns 1 after wait time is expired.
  3. Stop agent-two, keep agent-one running and verify system --wait returns 1 after wait time is expired.
  4. Stop both agents, run 'bluechi-is-online system --wait', start both agents and verify system --wait returns 0 before wait time is expired.
  5. Stop Controller, keep agents running, verify system --wait returns 1 after wait time is expired.

Fixes: #1020
Signed-off-by: Dana Orr [email protected]

@mkemel
Copy link
Member

mkemel commented Jan 27, 2025

/packit retest-failed

@coveralls
Copy link

coveralls commented Jan 27, 2025

Coverage Status

coverage: 82.236% (-0.02%) from 82.251%
when pulling 6e170c8 on DanaOrr:bluechi-is-online-system-wait
into d394690 on eclipse-bluechi:main.

@DanaOrr DanaOrr force-pushed the bluechi-is-online-system-wait branch from 308a5a4 to fef3a7a Compare January 30, 2025 11:29
@DanaOrr DanaOrr force-pushed the bluechi-is-online-system-wait branch from fef3a7a to a75e144 Compare January 30, 2025 11:40
@DanaOrr DanaOrr force-pushed the bluechi-is-online-system-wait branch from a75e144 to a955455 Compare January 30, 2025 13:00
1. Start node and two agents, keep it running and verify system --wait returns 0 immediately.
2. Stop agent-one, keep agent-two running and verify system --wait returns 1 after wait time is expired.
3. Stop agent-two, keep agent-one running and verify system --wait returns 1 after wait time is expired.
4. Stop both agents, run 'bluechi-is-online system --wait', start both agents and verify system --wait returns 0 before wait time is expired.
5. Stop Controller, keep agents running, verify system --wait returns 1 after wait time is expired.

Fixes: eclipse-bluechi#1020
Signed-off-by: Dana Orr <[email protected]>
@DanaOrr DanaOrr force-pushed the bluechi-is-online-system-wait branch from a955455 to 5b02c1c Compare February 2, 2025 13:04
Signed-off-by: Dana Orr <[email protected]>
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelmi engelmi merged commit ee89048 into eclipse-bluechi:main Feb 3, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests for bluechi-is-online system with --wait parameter
5 participants