-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration test for bluechi-is-online system --wait #1031
Merged
engelmi
merged 2 commits into
eclipse-bluechi:main
from
DanaOrr:bluechi-is-online-system-wait
Feb 3, 2025
Merged
Integration test for bluechi-is-online system --wait #1031
engelmi
merged 2 commits into
eclipse-bluechi:main
from
DanaOrr:bluechi-is-online-system-wait
Feb 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanaOrr
requested review from
alexlarsson,
engelmi,
mkemel and
rhatdan
as code owners
January 26, 2025 12:32
/packit retest-failed |
engelmi
reviewed
Jan 29, 2025
tests/tests/tier0/bluechi-is-online-system-wait/test_bluechi_is_online_system_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-system-wait/test_bluechi_is_online_system_wait.py
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-system-wait/test_bluechi_is_online_system_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-system-wait/test_bluechi_is_online_system_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-system-wait/test_bluechi_is_online_system_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-system-wait/test_bluechi_is_online_system_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-system-wait/test_bluechi_is_online_system_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-system-wait/test_bluechi_is_online_system_wait.py
Outdated
Show resolved
Hide resolved
DanaOrr
force-pushed
the
bluechi-is-online-system-wait
branch
from
January 30, 2025 11:29
308a5a4
to
fef3a7a
Compare
mwperina
reviewed
Jan 30, 2025
tests/tests/tier0/bluechi-is-online-node-wait/test_bluechi_is_online_node_wait.py
Show resolved
Hide resolved
DanaOrr
force-pushed
the
bluechi-is-online-system-wait
branch
from
January 30, 2025 11:40
fef3a7a
to
a75e144
Compare
mwperina
reviewed
Jan 30, 2025
tests/tests/tier0/bluechi-is-online-system-wait/test_bluechi_is_online_system_wait.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-system-wait/test_bluechi_is_online_system_wait.py
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-system-wait/test_bluechi_is_online_system_wait.py
Show resolved
Hide resolved
DanaOrr
force-pushed
the
bluechi-is-online-system-wait
branch
from
January 30, 2025 13:00
a75e144
to
a955455
Compare
1. Start node and two agents, keep it running and verify system --wait returns 0 immediately. 2. Stop agent-one, keep agent-two running and verify system --wait returns 1 after wait time is expired. 3. Stop agent-two, keep agent-one running and verify system --wait returns 1 after wait time is expired. 4. Stop both agents, run 'bluechi-is-online system --wait', start both agents and verify system --wait returns 0 before wait time is expired. 5. Stop Controller, keep agents running, verify system --wait returns 1 after wait time is expired. Fixes: eclipse-bluechi#1020 Signed-off-by: Dana Orr <[email protected]>
DanaOrr
force-pushed
the
bluechi-is-online-system-wait
branch
from
February 2, 2025 13:04
a955455
to
5b02c1c
Compare
Signed-off-by: Dana Orr <[email protected]>
mwperina
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mkemel
approved these changes
Feb 3, 2025
engelmi
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding integration test for bluechi-is-online system --wait with five tests:
Fixes: #1020
Signed-off-by: Dana Orr [email protected]