added intregration tests for AddPeer on Monitor API #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
force-pushed
the
integration-tests-add-peer
branch
5 times, most recently
from
b93efea to
c684d9f
Compare
dougsland
reviewed
Dec 7, 2023
|
In general LGTM, just a question raised. |
engelmi
force-pushed
the
integration-tests-add-peer
branch
2 times, most recently
from
02edc0d to
e582661
Compare
engelmi
force-pushed
the
integration-tests-add-peer
branch
from
e582661 to
e00b829
Compare
Relates to: eclipse-bluechi#187 Added integration tests to validate that the implemented API for adding and removing peers on monitors works as expected. Signed-off-by: Michael Engel <[email protected]>
In order to prevent duplicated signals being sent to a peer, the add peer method checks for the bus id and rejects if it can be found. This also applies to the owner of the monitor. Signed-off-by: Michael Engel <[email protected]>
Signed-off-by: Michael Engel <[email protected]>
engelmi
force-pushed
the
integration-tests-add-peer
branch
from
e00b829 to
90088e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #187
Added integration tests to validate that the implemented API for adding and removing peers on monitors works as expected.
Note:
I am not 100% happy about the current solution for starting two processes (which are necessary to get different bus IDs), but couldn't come up with a more elegant solution - all other options tend to be even more complex.