Prevent execution of the Java Resource Import Configurator #1288 #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ildship#1288 When importing Gradle projects from a folder with the generic project configurator, other configurators like the ProjectWithJavaResourcesImportConfigurator must not run. Otherwise resources in subprojects could be imported twice. To prevent the execution of secondary configurators the method shouldBeAnEclipseProject(...) has to return true for the root of Gradle projects.
donat
approved these changes
Jan 15, 2024
|
Thank you! |
|
@oleosterhagen I've mentioned you in the 3.1.9 release notes. Once again, thanks for all the work! We do appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1288
When importing Gradle projects from a folder with the generic project configurator, other configurators like the
ProjectWithJavaResourcesImportConfiguratormust not run. Otherwise resources in subprojects could be imported twice.To prevent the execution of secondary configurators the method
shouldBeAnEclipseProject(...)has to returntruefor the root of Gradle projects.Note: In the implementation of the integration test I have to wait for the
SmartImportJobto finish. Unfortunately the job family of this job is the non-API job class. This is why I usedClass.forName(...).