OSCORE: fix HMAC validation during context rederivation #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. |
|
As I wrote in your issue, I'm not common to OSCORE. @rikard-sics |
In the server handling of request eclipse-californium#2, the received HMAC was not being validated
burrrrrr
force-pushed
the
oscore-hmac-validation-fix
branch
from
3ebaf2c
to
f23da5a
Compare
Yes, I will have a look at this PR and the related issue. My initial impression is that the way to go is to stop the OSCORE layer from accepting requests from the client (with same token & MID) in the first place. |
|
Please see alternative PR #2296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #2294 but does not directly address it.
I found that the server was always accepting duplicate requests as valid for request 2 during context rederivation. It looks like the expected HMAC output is compared against itself, so the received context ID from the request is not validated.