Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node 20 and prettier fix #131

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

jreineckearm
Copy link
Contributor

@jreineckearm jreineckearm commented Jan 15, 2025

Follow up to #130 , related to #119 :

This PR

  • Updates Node to version 20 for CI. Required by latest vsce version, and unblocks version bumps for other dependencies.
  • Fixes lint script which was broken due to missing dev dependency eslint-config-prettier to integrate prettier with eslint.
  • Fixes two minor issues found by linter. Linter not activated in CI yet.

The CI build step should now complete.

Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
@eclipse-cdt-bot
Copy link
Contributor

Can one of the admins verify this patch?

@jreineckearm
Copy link
Contributor Author

jreineckearm commented Jan 15, 2025

Oh, I just noticed that part of this was addressed in #109 . Without updating rules in this PR here. (CC: @colin-grant-work )

Copy link

@thegecko thegecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thegecko thegecko merged commit 636278c into eclipse-cdt-cloud:main Jan 15, 2025
5 checks passed
@jreineckearm jreineckearm deleted the node-20-update branch January 15, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants