Add separators to context menu #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of menu items in the memory inspector's context menu already contributes to a convoluted list. In this change we add separators grouping those that are related to each other.
colin-grant-work
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The number of menu items in the memory inspector's context menu already contributes to a convoluted list. In this change we add separators grouping those that are related to each other. To be consistent with other core context menu entires, I also added
...to those menu items, where additional input will be required.How to test
This change only re-groups them to realize separators, so there is nothing more to test other than the grouping matches the expectations.
Review checklist
Reminder for reviewers