-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General improvements of the styling #130
Conversation
* Properly aligning the icons in the memory widget * Aligning and line breaking in the address / offset / length area * Better spacing and coloring in the advanced options overlay * Adding own scrollbar in the advanced options overlay * Avoid line breaking in the label column of the hover
Thank you for your feedback! I've briefly looked into the two findings.
I'm afraid, primereact dynamically sets the |
Thanks for investigating! I agree that now probably isn't the right time for it. Let's see if real users come back with feedback about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for clarifying that the feedback cannot be addressed without further investigation. This shouldn't become a blocker for the set of improvements, especially the ability to scroll through the advance options dialogs without losing the current position in the memory contents.
Good from my side to get merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What it does
How to test
Test how you feel the layouting looks in the upper part of the memory inspector and the options overlay. Try different themes too. Also try resizing the view to observe how the flex components break into new lines.
Review checklist
Reminder for reviewers