Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General improvements of the styling #130

Merged
merged 1 commit into from
May 6, 2024

Conversation

planger
Copy link
Contributor

@planger planger commented Apr 29, 2024

What it does

  • Properly aligning the icons in the memory widget
  • Aligning and line breaking in the address / offset / length area
  • Better spacing and coloring in the advanced options overlay
  • Adding own scrollbar in the advanced options overlay
  • Avoid line breaking in the label column of the hover

image

image

image

How to test

Test how you feel the layouting looks in the upper part of the memory inspector and the options overlay. Try different themes too. Also try resizing the view to observe how the flex components break into new lines.

Review checklist

Reminder for reviewers

* Properly aligning the icons in the memory widget
* Aligning and line breaking in the address / offset / length area
* Better spacing and coloring in the advanced options overlay
* Adding own scrollbar in the advanced options overlay
* Avoid line breaking in the label column of the hover
@planger planger requested a review from jreineckearm April 29, 2024 14:06
@jreineckearm
Copy link
Contributor

Changes look good!

Two findings which I can confirm to have been there before your changes:

  • If you have reduce height of the window while the advanced options pop-up is open, then the pop-up jumps upwards and overlays the options button.
    image
    image

  • The pop-up overlays the main window scrollbar. Probably not super-problematic as the expectation would be that the advanced option dialog is not present when navigating through the data.

@planger
Copy link
Contributor Author

planger commented Apr 30, 2024

Thank you for your feedback! I've briefly looked into the two findings.

  • If you have reduce height of the window while the advanced options pop-up is open, then the pop-up jumps upwards and overlays the options button.
  • The pop-up overlays the main window scrollbar. Probably not super-problematic as the expectation would be that the advanced option dialog is not present when navigating through the data.

I'm afraid, primereact dynamically sets the top and left style attribute in the element style directly. I guess we could customize this dynamic behavior, but it isn't quite as straightforward as just setting a value, as far as I could determine in the docs. So I'm not sure it is worth pursuing this. What do you think?

@jreineckearm
Copy link
Contributor

So I'm not sure it is worth pursuing this. What do you think?

Thanks for investigating! I agree that now probably isn't the right time for it. Let's see if real users come back with feedback about this.

@planger planger marked this pull request as ready for review May 2, 2024 06:49
@planger planger requested a review from colin-grant-work May 3, 2024 15:56
Copy link
Contributor

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for clarifying that the feedback cannot be addressed without further investigation. This shouldn't become a blocker for the set of improvements, especially the ability to scroll through the advance options dialogs without losing the current position in the memory contents.

Good from my side to get merged.

Copy link

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@planger planger merged commit b0046d4 into eclipse-cdt-cloud:main May 6, 2024
5 checks passed
@planger planger deleted the css-overhaul branch May 6, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants