Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer workspace extension host #151

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Prefer workspace extension host #151

merged 1 commit into from
Dec 23, 2024

Conversation

thegecko
Copy link
Contributor

@thegecko thegecko commented Nov 7, 2024

What it does

This changes the exensionKind so that the extension prefers to run in the workspace. This enables remote VS Code sessions (e.g. WSL, ssh-remote, codespaces) to execute the memory inspector in the workspace where the debugger is more likely to be. Fixes #150

How to test

Run a debugger in WSL and use this extension

Review checklist

Reminder for reviewers

Copy link

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'm not sure how wide our adopter base is, but if we can communicate this somehow - at least a changelog entry? - that would probably be good, since it could ruin someone's day if they're using a browser debugger.

@thegecko
Copy link
Contributor Author

thegecko commented Nov 7, 2024

but if we can communicate this somehow - at least a changelog entry?

👍 Added a changelog entry

@thegecko thegecko merged commit 3beb8c8 into main Dec 23, 2024
5 checks passed
@thegecko thegecko deleted the remote-support branch December 23, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running the memoryinspector in WSL
2 participants