Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to configure word size and add group separator #80

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Allow to configure word size and add group separator #80

merged 5 commits into from
Feb 22, 2024

Conversation

planger
Copy link
Contributor

@planger planger commented Feb 21, 2024 •
edited
Loading

What it does

  • Introduces user option for bytes per word (VS Code settings & per view)
  • Rename "Bytes per Group" into "Words per Group"
  • Add right margin to groups

Fixes #74
Fixes #75

How to test

  • Start debug session and open two memory view instances
  • Verify there are separating spaces between groups
  • Change bytes per word and check it is applied correctly to the memory data in the individual views
  • Use the reset settings button in the options and verify they are reset correctly
  • Change the VS Code settings regarding "Bytes per Word"
  • Use the reset settings button again to check the new settings are applied

Review checklist

Reminder for reviewers

colin-grant-work
colin-grant-work reviewed Feb 21, 2024
View reviewed changes
src/common/memory-range.ts Outdated Show resolved Hide resolved
src/plugin/memory-webview-main.ts Outdated Show resolved Hide resolved
@planger planger force-pushed the issues/74-75 branch 2 times, most recently from fb8916c to 37fa1dc Compare February 22, 2024 08:36
@planger
Allow to configure word size and add group separator
66eb6ec 
* Introduces user option for bytes per word (VS Code settings & per view)
* Rename "Bytes per Group" into "Words per Group"
* Add right margin to groups

Fixes eclipse-cdt-cloud#74
Fixes eclipse-cdt-cloud#75
@planger
Copy link
Contributor Author

planger commented Feb 22, 2024

Thanks for the review @colin-grant-work! I've added your changes and resolved all conflicts. Thanks again!

@colin-grant-work colin-grant-work merged commit d1400a1 into eclipse-cdt-cloud:main Feb 22, 2024
5 checks passed
@colin-grant-work
Copy link

Thanks for breaking out the individual PR's - that made it much easier to review each one. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add space separator between groups in memory data Allow to configure word size
2 participants
@planger @colin-grant-work