use UTF-8 as default encoding

[astrograph]

the rest of Eclipse now uses UTF-8 as default encoding.

The tm.terminal code reverts to null when the encoding begins with "Default" and this leads to UTF-8 being selected from Charset.defaultEncoding in stead of ISO-8859 when the displayed default value is selected.

[jonahgraham]

Thanks @astrograph

The next release is a major release, so this change is well timed as we have a bit more freedom to change defaults, etc.

I think a little more needs to be done to change this, for example this line looks like it needs updating too

cdt/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/panels/AbstractExtendedConfigurationPanel.java

Line 615 in a9a7e8b

int index = encodingCombo.indexOf("ISO-8859-1".equals(encoding) ? "Default (ISO-8859-1)" : encoding); //$NON-NLS-1$ //$NON-NLS-2$

There are a few other places that look like an incorrect default is in place too? search for ISO-8859-1 in terminal/**/*.java

WDYT?

[astrograph]

Thanks @astrograph

The next release is a major release, so this change is well timed as we have a bit more freedom to change defaults, etc.

I think a little more needs to be done to change this, for example this line looks like it needs updating too

cdt/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/panels/AbstractExtendedConfigurationPanel.java

Line 615 in a9a7e8b

int index = encodingCombo.indexOf("ISO-8859-1".equals(encoding) ? "Default (ISO-8859-1)" : encoding); //$NON-NLS-1$ //$NON-NLS-2$

There are a few other places that look like an incorrect default is in place too? search for ISO-8859-1 in terminal/**/*.java

WDYT?

I added a commit with some more changes to reflect the new default encoding, I think these are all occurances

[github-actions]

Test Results

   601 files  ±0     601 suites  ±0   12m 50s ⏱️ -24s
10 200 tests ±0  10 177 ✅ ±0  23 💤 ±0  0 ❌ ±0 
10 238 runs  ±0  10 215 ✅ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit 01e3b03. ± Comparison against base commit 957bb48.

♻️ This comment has been updated with latest results.

[jonahgraham]

There are some IT issues that I am trying to resolve + wait on Eclipse IT team for. Please disregard any failed builds or other failed checks for now.

[jonahgraham]

Looks great. Thanks @astrograph for the improvement!

I added a N&N entry

Once CI passes I can submit this.