Add some documentation and consistency to use of info vs output stream #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With some better Javadocs the cross referencing between IConsole and the UI aspects of the console is a little easier to follow. This resolves eclipse-cdt#1059 in two parts: 1. For Core Build System this update consistently uses info stream to show information messages and output stream to be stdout of launched build tool. This resolves the "Build Complete" appearing as the output color when doing clean (See screenshots in eclipse-cdt#1059) 2. CBuildConfiguration.watchProcess(IConsole, IProgressMonitor) incorrectly passed the info stream as the output stream. Mostly this was used for the clean stage of builds. This resolves the CMake output like ("Cleaning all built files...") appearing as the info color when doing clean (See screenshots in eclipse-cdt#1059) Fixes eclipse-cdt#1059
Test Results 600 files - 34 600 suites - 34 13m 29s ⏱️ - 23m 6s Results for commit c3c5607. ± Comparison against base commit 62faf42. This pull request removes 1217 tests. |
Hmm. A side of effect of making this comment work is that it compares to the last build of HEAD. However since we run different numbers of tests depending on whether debug tests have been suppressed we get this unexpected warning about removing tests. The tests were not removed, they were just not run this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some better Javadocs the cross referencing between IConsole and the UI aspects of the console is a little easier to follow.
This resolves #1059 in two parts:
For Core Build System this update consistently uses info stream to show information messages and output stream to be stdout of launched build tool. This resolves the "Build Complete" appearing as the output color when doing clean (See screenshots in CMake Clean has inverted colors compared to build #1059)
CBuildConfiguration.watchProcess(IConsole, IProgressMonitor) incorrectly passed the info stream as the output stream. Mostly this was used for the clean stage of builds. This resolves the CMake output like ("Cleaning all built files...") appearing as the info color when doing clean (See screenshots in CMake Clean has inverted colors compared to build #1059)
Fixes #1059
Here are some after screenshots, see #1059 for the before screenshots: