Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.eclipse.cdt.core/ui bundle version to 9.0.0 #1063

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

jonahgraham
Copy link
Member

Some of the changes that are about to arrive have specific impacts of API of core build. Because CBS is largely in org.eclipse.cdt.core/ui any breaking changes to the CBS API necessitate bumping the entire bundle to a new version.

One of the most noticeable changes is expected to be that org.eclipse.cdt.core.build.ICBuildConfigurationProvider.createBuildConfiguration(IProject, IToolChain, String, IProgressMonitor) needs a new parameter to properly connect the target. The upcoming PR that makes the API change will document that change in the CHANGELOG-API.md and N&N documentation.

Part of #1000

@jonahgraham
Copy link
Member Author

cc: @betamaxbandit

@jonahgraham jonahgraham changed the title Bump org.eclipse.cdt.core/ui bundle version to CDT 9.0.0 Bump org.eclipse.cdt.core/ui bundle version to 9.0.0 Jan 29, 2025
@jonahgraham jonahgraham added this to the 12.0.0 M2 milestone Jan 29, 2025
Copy link

github-actions bot commented Jan 29, 2025

Test Results

   634 files  +   634     634 suites  +634   35m 49s ⏱️ + 35m 49s
11 423 tests +11 423  11 280 ✅ +11 280  143 💤 +143  0 ❌ ±0 
11 438 runs  +11 438  11 297 ✅ +11 297  141 💤 +141  0 ❌ ±0 

Results for commit c2278fd. ± Comparison against base commit 84d99f2.

♻️ This comment has been updated with latest results.

@jonahgraham

This comment was marked as outdated.

@jonahgraham
Copy link
Member Author

I would like to merge and build this version bump today so that we can contribute an update 12.0 M2 to SimRel so all consumers of CDT API see the version bump as soon as possible. Deadline for this is today.

If anyone has thoughts or concerns, kindly let me know.

Some of the changes that are about to arrive have specific impacts
of API of core build. Because CBS is largely in org.eclipse.cdt.core/ui
any breaking changes to the CBS API necessitate bumping the entire
bundle to a new version.

One of the most noticeable changes is expected to be that
org.eclipse.cdt.core.build.ICBuildConfigurationProvider.createBuildConfiguration(IProject, IToolChain, String, IProgressMonitor)
needs a new parameter to properly connect the target. The upcoming
PR that makes the API change will document that change in the
CHANGELOG-API.md and N&N documentation.

Part of eclipse-cdt#1000
Copy link
Contributor

@betamaxbandit betamaxbandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahgraham jonahgraham merged commit 0fcf41a into eclipse-cdt:main Jan 29, 2025
5 checks passed
@jonahgraham jonahgraham deleted the cdt.core.9 branch January 29, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants