Issue #1058: Moved generation of the compile_commands.json #1075
+27
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgraham
reviewed
Feb 3, 2025
| CompilationDatabaseGenerator generator = new CompilationDatabaseGenerator(getProject(), activeCfg); | ||
| generator.generate(); | ||
| } | ||
| for (int i = 0; i < num; i++) { |
There was a problem hiding this comment.
The code cleanliness checks are going to fail because of trailing whitespace here
Suggested change
| for (int i = 0; i < num; i++) { | |
| for (int i = 0; i < num; i++) { |
Moved compile_commands.json file to performPrebuildGeneration, so the file to be generated only when Makefiles generation is set to be on.
alicetrifu
force-pushed
the
MBSProjectsCondition
branch
from
fcfdaef to
839f30a
Compare
|
Thanks @alicetrifu for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved compile_commands.json file to performPrebuildGeneration, so the file to be generated only when Makefiles generation is set to be on.