Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launchbar build button always starts a build. #812

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

ewaterlander
Copy link
Contributor

Fixed the problem that the LaunchBar build button was not working when auto build was disabled in the launch configuration.

Fixes #765

Fixed the problem that the LaunchBar build button was not working when
auto build was disabled in the launch configuration.

Fixes eclipse-cdt#765
@ewaterlander
Copy link
Contributor Author

This change added a dependency to org.eclipse.cdt.debug.core. I hope it's OK.

@jonahgraham
Copy link
Member

@betamaxbandit this issue sounds like it would affect you too. Can you have a look.

@ewaterlander
Copy link
Contributor Author

This change affects every C/C++ project that is launched via a C/C++ launch configuration that has the option to disable auto-build, including Managed Build.

@betamaxbandit
Copy link
Contributor

Hi @ewaterlander ,
I still plan to review this. Hopefully will get to it soon.
Cheers John

@ewaterlander
Copy link
Contributor Author

Hi @ewaterlander , I still plan to review this. Hopefully will get to it soon. Cheers John

Hi @betamaxbandit , do you have some time to review this change?

@jonahgraham jonahgraham merged commit 19a809d into eclipse-cdt:main Sep 12, 2024
5 checks passed
@ewaterlander ewaterlander deleted the launchbar_build_button branch September 13, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable autobuild in launch configuration disables also manual build via the LaunchBar build button.
3 participants