Fixed the loading failure issue of Control Flow Graph view #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Show View ->Other... ->C/C++->Control Flow Graph).
|
@homeiceberg Thank you for the contribution. Can you please sign the contributor agreement so that we can review and merge your improvement. Please see the contribution guide's entry on the Eclipse Contributor Agreement |
|
@jonahgraham I have signed the Eclipse Contributor Agreement，please approve it，thank you |
jonahgraham
approved these changes
Dec 17, 2024
jonahgraham
approved these changes
Dec 17, 2024
|
Thanks you @homeiceberg for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear committers:
Before fixing the issue：
The source code was like this：public static final String PLUGIN_ID = "org.eclipse.cdt.codan.ui.cfgview";
As shown in the following figure, when the CDT project is running, the Control Flow Graph view throws an exception.
After fixing the issue：
The source code was like this：public static final String PLUGIN_ID = "org.eclipse.cdt.codan.ui.example.cfgview";
As shown in the following figure, when the CDT project is running, the Control Flow Graph view runs normally.
Conduct impact analysis on code changes:
As shown in the following figure, the Plugin ID member variable is called by these three functions
By analyzing these three calling functions, only the image resource loading function and logging function are affected, so this code change will not affect other functions.