Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common tab for Core Build local launch configuration. #970

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Common tab for Core Build local launch configuration. #970

merged 3 commits into from
Dec 15, 2024

Conversation

ewaterlander
Copy link
Contributor

Added the Common tab. For instance handy for redirecting program output to a file.

@ewaterlander
Common tab for Core Build local launch configuration.
8bf7045 
Added the Common tab. For instance handy for redirecting program
output to a file.
@ewaterlander
Copy link
Contributor Author

Hi @jonahgraham and @betamaxbandit ,
Would you like to review this change?

jonahgraham
jonahgraham approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I am going to push the undoing of the version bumps, and if that builds successfully I think this is ready to go.

dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/META-INF/MANIFEST.MF Outdated Show resolved Hide resolved
launch/org.eclipse.cdt.launch/META-INF/MANIFEST.MF Outdated Show resolved Hide resolved
@jonahgraham jonahgraham merged commit 139fe3d into eclipse-cdt:main Dec 15, 2024
3 checks passed
@ewaterlander ewaterlander deleted the common_tab branch December 16, 2024 08:15
@ewaterlander
Copy link
Contributor Author

Thanks for merging.
This change relates to #758
The tabs for local Core Build launch configuration are now complete. We now have the familiar picture of the launch configuration, comparable to MBS local launch configuration.

image

@ewaterlander ewaterlander mentioned this pull request Dec 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahgraham jonahgraham jonahgraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewaterlander @jonahgraham