Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning notification on fetch token error when starting a work… #1179

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

vinokurig
Copy link
Contributor

…space

What does this PR do?

Show a warning notification on fetch token error when starting a workspace.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#23076

Is it tested? How?

see eclipse-che/che-server#715

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Aug 30, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]"

@vinokurig vinokurig marked this pull request as draft August 30, 2024 14:24
@vinokurig vinokurig marked this pull request as ready for review September 3, 2024 10:44
@vinokurig
Copy link
Contributor Author

/retest

Copy link

github-actions bot commented Sep 3, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]"

@vinokurig vinokurig force-pushed the che-23076 branch 3 times, most recently from 9df5749 to d57dacd Compare September 11, 2024 12:58
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]"

3 similar comments
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]"

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]"

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]"

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]"

1 similar comment
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]"

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]"

@ibuziuk
Copy link
Member

ibuziuk commented Sep 16, 2024

@olexii4 @akurinnoy since Igor is on PTO this week, we should either merge it as is if in principal all good, or somebody from dashboard side need to provide update on this PR with required changes

@vinokurig
Copy link
Contributor Author

@ibuziuk It was a one day PTO so I am available from today. I will address the pr comments today.

@openshift-ci openshift-ci bot removed the lgtm label Sep 17, 2024
@vinokurig vinokurig force-pushed the che-23076 branch 3 times, most recently from dfb4e13 to df19e06 Compare September 17, 2024 10:43
Copy link

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, olexii4, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Sep 17, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Sep 17, 2024

@vinokurig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-dashboard-happy-path d91ca1c link true /test v14-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vinokurig vinokurig force-pushed the che-23076 branch 3 times, most recently from 5352745 to 6916e23 Compare September 17, 2024 12:42
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]"

@vinokurig vinokurig merged commit e1fe428 into main Sep 17, 2024
15 of 16 checks passed
@vinokurig vinokurig deleted the che-23076 branch September 17, 2024 14:08
@devstudio-release
Copy link

Build 3.17 :: dashboard_3.x/544: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants