Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix factory flow with SSH URL #1281

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Fix factory flow with SSH URL #1281

merged 1 commit into from
Dec 23, 2024

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR fixes the ability to create workspaces using SSH URLs.

What issues does this PR fix or reference?

fixes eclipse-che/che#23294

Is it tested? How?

See steps to reproduce eclipse-che/che#23294

@akurinnoy akurinnoy self-assigned this Dec 20, 2024
@che-bot
Copy link
Contributor

che-bot commented Dec 20, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1281

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1281", name: che-dashboard}]}}]"

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.71%. Comparing base (1790beb) to head (98132e3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1281      +/-   ##
==========================================
- Coverage   91.87%   91.71%   -0.17%     
==========================================
  Files         499      499              
  Lines       45653    45654       +1     
  Branches     3188     3171      -17     
==========================================
- Hits        41944    41871      -73     
- Misses       3678     3753      +75     
+ Partials       31       30       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy akurinnoy merged commit a78aeba into main Dec 23, 2024
20 of 21 checks passed
@akurinnoy akurinnoy deleted the fix-ssh-factory branch December 23, 2024 15:07
@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/608: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not create a workspace using ssh
4 participants