-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix factory flow with SSH URL #1281
Conversation
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1281 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1281", name: che-dashboard}]}}]" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1281 +/- ##
==========================================
- Coverage 91.87% 91.71% -0.17%
==========================================
Files 499 499
Lines 45653 45654 +1
Branches 3188 3171 -17
==========================================
- Hits 41944 41871 -73
- Misses 3678 3753 +75
+ Partials 31 30 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.19 :: dashboard_3.x/608: Console, Changes, Git Data |
Build 3.19 :: sync-to-downstream_3.x/8375: Console, Changes, Git Data |
What does this PR do?
This PR fixes the ability to create workspaces using SSH URLs.
What issues does this PR fix or reference?
fixes eclipse-che/che#23294
Is it tested? How?
See steps to reproduce eclipse-che/che#23294