This repository has been archived by the owner on Feb 2, 2022. It is now read-only.
Ubuntu without JDK, additional latest Ubuntu LTS and JDK11 #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Also added new ubuntu image vor the actual LTS.
|
I saw that I have to sign the ECA and signed it now. ;) |
|
@eivantsov Can you review this proposal, please? |
|
This PR will break all stack images for Che. We need Java in all of them and that is why it is installed in a base image from which other images inherit. Also, @dneary I think we should not expand our ready to go stacks for several reasons: 1. maintenance 2. Che 7 coming soon |
|
Thanks Eugene. Why do we need Java in every stack image? Also: I was not suggesting that this patch was ready to merge - I just noticed it had not yet been reviewed, and thought you would be able to help, and provide guidance to @Nicklas2751 about what to change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I moved the JDK installation from the ubuntu base image to the ubuntu_jdkX images to make it possible to create images with other JDK versions based on the same base image. I also added a new ubuntu base image called ubuntu_lts with the latest lts version (18.04) but this is only a workaround until #214 got merged. The ubuntu_lts image is the base for the new ubuntu_jdk11 image I also added.
After my changes i builded all images with the build.sh via gitlab-ci on a private gitlab instance to check if all images build.
What issues does this PR fix or reference?
Previous behavior
New behavior
Tests written?
No automatic test but builded all images with gitlab-ci on a private gitlab instance.
Docs updated?
No