Remove devfile v1 leftovers

[vinokurig]

What does this PR do?

Remove devfile v1 leftovers

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#23043

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[openshift-ci]

@vinokurig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v14-gitlab-with-oauth-setup-flow	eb28272	link	true	/test v14-gitlab-with-oauth-setup-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[tolusha]

Do we ignore overrideProperties ?

[vinokurig]

Yes, this is used only for devfile v1:

che-server/wsmaster/che-core-api-factory/src/main/java/org/eclipse/che/api/factory/server/urlfactory/URLFactoryBuilder.java

Lines 179 to 187 in 3445db7

	if (devfileVersionDetector.devfileMajorVersion(devfileJson) == 1) {
	DevfileImpl devfile = devfileParser.parseJsonNode(devfileJson, overrideProperties);
	devfileParser.resolveReference(devfile, fileContentProvider);
	devfile = ensureToUseGenerateName(devfile);
	return newDto(FactoryDto.class)
	.withV(CURRENT_VERSION)
	.withDevfile(DtoConverter.asDto(devfile))
	.withSource(location.filename().isPresent() ? location.filename().get() : null);

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[devstudio-release]

Build 3.17 :: server_3.x/358: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: sync-to-downstream_3.x/7700: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7692: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7692:

server : 3.x :: Failed in 64158757 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay