Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat azure devops redirect response as unauthorized error (#755) #759

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

vinokurig
Copy link
Contributor

Handle the 302 redirect response in the azure devops api client and throw unauthorized exception, so the dashboard can handle it properly. Also add 401 unauthorized and 403 forbidden to the unauthorized case.

What does this PR do?

cherry-pick from #755

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Handle the 302 redirect response in the azure devops api client and throw unauthorized exception, so the dashboard can handle it properly. Also add 401 unauthorized and 403 forbidden to the unauthorized case.
@SkorikSergey
Copy link
Contributor

All Azure factories with OAuth test-cases passed successfully with PR-755 fix

Copy link

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SkorikSergey, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig vinokurig merged commit 00bf0fb into 7.95.x Jan 24, 2025
6 checks passed
@vinokurig vinokurig deleted the che-23306_7.95 branch January 24, 2025 13:49
@devspacesbuild
Copy link

Build 3.18 :: server_3.18/5: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.18 :: server_3.18/5: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.18/359 triggered

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.18 :: sync-to-downstream_3.18/360: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.18/368 triggered; /job/DS_CI/job/dsc_3.18 triggered;

@devspacesbuild
Copy link

Build 3.18 :: operator-bundle_3.18/302: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.18/360 triggered

@devstudio-release
Copy link

Build 3.18 :: copyIIBsToQuay/2903: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.18 :: update-digests_3.18/374: SUCCESS

Detected new images: rebuild operator-bundle
* server; /DS_CI/operator-bundle_3.18/302 triggered

@devspacesbuild
Copy link

Build 3.18 :: dsc_3.18/15: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.18 :: dsc_3.18/15: SUCCESS

3.18.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants