-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat azure devops redirect response as unauthorized error (#755) #759
Conversation
Handle the 302 redirect response in the azure devops api client and throw unauthorized exception, so the dashboard can handle it properly. Also add 401 unauthorized and 403 forbidden to the unauthorized case.
All Azure factories with OAuth test-cases passed successfully with PR-755 fix |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SkorikSergey, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.18 :: server_3.18/5: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.18/359: Console, Changes, Git Data |
Build 3.18 :: push-latest-container-to-quay_3.18/47: Console, Changes, Git Data |
Build 3.18 :: get-sources-rhpkg-container-build_3.18/367: server : 3.18 :: Build 66478511 : quay.io/devspaces/server-rhel9:3.18-2 |
Build 3.18 :: update-digests_3.18/374: Console, Changes, Git Data |
Build 3.18 :: server_3.18/5: Upstream sync done; /DS_CI/sync-to-downstream_3.18/359 triggered |
Build 3.18 :: operator-bundle_3.18/302: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.18/360: Console, Changes, Git Data |
Build 3.18 :: push-latest-container-to-quay_3.18/48: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.18/360: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.18/368 triggered; /job/DS_CI/job/dsc_3.18 triggered; |
Build 3.18 :: operator-bundle_3.18/302: Upstream sync done; /DS_CI/sync-to-downstream_3.18/360 triggered |
Build 3.18 :: copyIIBsToQuay/2903: Console, Changes, Git Data |
Build 3.18 :: update-digests_3.18/374: Detected new images: rebuild operator-bundle |
Build 3.18 :: dsc_3.18/15: Console, Changes, Git Data |
Build 3.18 :: dsc_3.18/15: 3.18.0-CI |
Handle the 302 redirect response in the azure devops api client and throw unauthorized exception, so the dashboard can handle it properly. Also add 401 unauthorized and 403 forbidden to the unauthorized case.
What does this PR do?
cherry-pick from #755
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.