Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the locator of 'workspace current status' according the changes on Dashboard UI #22717

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

artaleks9
Copy link
Contributor

@artaleks9 artaleks9 commented Dec 1, 2023

What does this PR do?

  • Fixes the locator of the workspace's current status according the changes on Dashboard
  • Fixes the E2E tests related to stop and delete workspace method

Screenshot/screencast of this PR

What issues does this PR fix or reference?

#22698
Related to PR: eclipse-che/che-dashboard#1014

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@artaleks9 artaleks9 changed the title Update the locator of 'workspace current status' according the changes on Dashboard UI [WIP] Update the locator of 'workspace current status' according the changes on Dashboard UI Dec 1, 2023
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Dec 1, 2023
@artaleks9 artaleks9 changed the title [WIP] Update the locator of 'workspace current status' according the changes on Dashboard UI Update the locator of 'workspace current status' according the changes on Dashboard UI Dec 1, 2023
@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Dec 1, 2023

@artaleks9 : Smoke test from this PR has failed being run against Dev Spaces Next because of new error:

21:38:59    [ERROR] DriverHelper.waitVisibility - failed with exception, out of attempts - TimeoutError: Waiting for element to be located By(xpath, //tr[td//a[text()='quarkus-api-example-ry8d']]//span[@data-testid='workspace-status-indicator' and @aria-label='Workspace status is Running'])

https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/16292/console

As could be seen at [1], there was no @aria-label='Workspace status is Running' at the workspaces page:
Screenshot from 2023-12-01 21-57-52

[1] https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/16292/artifact/test-repo/tests/e2e/report/The_SmokeTest_userstory__Create_workspace_from_factory-https-++github.com+che-incubator+quarkus-api-example.git_Stop_the_workspace_by_UI/pagesource-Stop_the_workspace_by_UI.html

It would be appreciated if you could take a look.

@artaleks9
Copy link
Contributor Author

@dmytro-ndp
It's because, the PR applies the changes of this PR
I marked it in the description.

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Dec 4, 2023

@artaleks9: I see.
I would suggest to wait on Dev Spaces Next with changes and run the test again.

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artaleks9 artaleks9 merged commit b77168c into main Dec 5, 2023
2 checks passed
@artaleks9 artaleks9 deleted the che#22698 branch December 5, 2023 10:00
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants