Fixed many clang tidy warnings

eclipse-ecal · Aug 2, 2023 · 6068b7d · 6068b7d
1 parent a3b4670
commit 6068b7d
Show file tree

Hide file tree

Showing 6 changed files with 64 additions and 62 deletions.
diff --git a/ecal/service/src/client_session_impl_v0.cpp b/ecal/service/src/client_session_impl_v0.cpp
@@ -64,6 +64,7 @@ namespace eCAL
 
     ClientSessionV0::~ClientSessionV0()
     {
+      ClientSessionV0::stop();
       ECAL_SERVICE_LOG_DEBUG_VERBOSE(logger_, "Deleted");
     }
 

diff --git a/ecal/service/src/client_session_impl_v1.cpp b/ecal/service/src/client_session_impl_v1.cpp
@@ -68,6 +68,7 @@ namespace eCAL
 
     ClientSessionV1::~ClientSessionV1()
     {
+      ClientSessionV1::stop();
       ECAL_SERVICE_LOG_DEBUG_VERBOSE(logger_, "Deleted");
     }
 
@@ -151,7 +152,7 @@ namespace eCAL
                                     {
                                       asio::error_code socket_option_ec;
                                       {
-                                        std::lock_guard<std::mutex> socket_lock (me->socket_mutex_);
+                                        const std::lock_guard<std::mutex> socket_lock(me->socket_mutex_);
                                         me->socket_.set_option(asio::ip::tcp::no_delay(true), socket_option_ec);
                                       }
                                       if (socket_option_ec)

diff --git a/ecal/service/src/server_session_impl_base.h b/ecal/service/src/server_session_impl_base.h
@@ -85,7 +85,7 @@ namespace eCAL
     public:
       asio::ip::tcp::socket& socket() { return socket_; }
       virtual void start() = 0;
-      virtual void stop()  = 0;
+      virtual void stop() = 0;
 
       virtual eCAL::service::State get_state() const = 0;
 

diff --git a/ecal/service/src/server_session_impl_v0.cpp b/ecal/service/src/server_session_impl_v0.cpp
@@ -60,6 +60,7 @@ namespace eCAL
     // Destructor
     ServerSessionV0::~ServerSessionV0()
     {
+      ServerSessionV0::stop();
       ECAL_SERVICE_LOG_DEBUG_VERBOSE(logger_, "Server Session Deleted");
     }
 

diff --git a/ecal/service/src/server_session_impl_v1.cpp b/ecal/service/src/server_session_impl_v1.cpp
@@ -63,7 +63,7 @@ namespace eCAL
     // Destructor
     ServerSessionV1::~ServerSessionV1()
     {
-      stop();
+      ServerSessionV1::stop();
       ECAL_SERVICE_LOG_DEBUG_VERBOSE(logger_, "Server Session Deleted");
     }