Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fixed a bug that may have caused drops in the SHM Layer #1198

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

FlorianReimold
Copy link
Member

@FlorianReimold FlorianReimold commented Sep 13, 2023

Description

Prior to this commit, SHM data was dropped, if the subscriber wasn't able to access it in 5ms. Now, the subscriber re-tries, until it got access to it, or new data is available.

Related issues

Cherry-pick to

  • 5.11 (old stable)
  • 5.12 (current stable)

Prior to this commit, SHM data was dropped, if the subscriber wasn't able to access it in 5ms. Now, the subscriber re-tries, until it got access to it, or new data is available.
@FlorianReimold
Copy link
Member Author

TODO: Test with ecal-perftool and large payloads

Copy link
Contributor

@KerstinKeller KerstinKeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it

@FlorianReimold FlorianReimold merged commit 87d0ade into master Sep 29, 2023
13 checks passed
FlorianReimold added a commit that referenced this pull request Oct 26, 2023
Prior to this commit, SHM data was dropped, if the subscriber wasn't able to access it in 5ms. Now, the subscriber re-tries, until it got access to it, or new data is available.
FlorianReimold added a commit that referenced this pull request Oct 26, 2023
Prior to this commit, SHM data was dropped, if the subscriber wasn't able to access it in 5ms. Now, the subscriber re-tries, until it got access to it, or new data is available.
FlorianReimold added a commit that referenced this pull request Oct 27, 2023
Prior to this commit, SHM data was dropped, if the subscriber wasn't able to access it in 5ms. Now, the subscriber re-tries, until it got access to it, or new data is available.
FlorianReimold added a commit that referenced this pull request Oct 27, 2023
Prior to this commit, SHM data was dropped, if the subscriber wasn't able to access it in 5ms. Now, the subscriber re-tries, until it got access to it, or new data is available.
@FlorianReimold FlorianReimold deleted the hotfix/shm_data_drop branch November 8, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants