Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved logging for shm memfile handling #1225

Merged
merged 1 commit into from
Oct 25, 2023
Merged

improved logging for shm memfile handling #1225

merged 1 commit into from
Oct 25, 2023

Conversation

rex-schilasky
Copy link
Contributor

@rex-schilasky rex-schilasky commented Oct 24, 2023 •
edited
Loading

Description

  • additional logging added for shm memfile creation/handling
  • return values of ShmSetBufferCount evaluated in CDataWriterSHM::Create function to state failed creation

Cherry-pick to

  • 5.12 (current stable) - additional logging needed to better debug shm memfile handling issues

@rex-schilasky
additional logging added for shm memfile creation/handling
5fcd351 
return values of ShmSetBufferCount evaluated in CSyncMemoryFile::Create function to state failed creation
@rex-schilasky rex-schilasky marked this pull request as draft October 24, 2023 14:17
KerstinKeller
KerstinKeller approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@KerstinKeller KerstinKeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@rex-schilasky rex-schilasky marked this pull request as ready for review October 25, 2023 15:01
@rex-schilasky rex-schilasky merged commit 5f433cc into master Oct 25, 2023
14 checks passed
@rex-schilasky rex-schilasky deleted the feature/improved_shm_logging branch October 25, 2023 15:04
FlorianReimold pushed a commit that referenced this pull request Oct 26, 2023
@rex-schilasky @FlorianReimold
additional logging added for shm memfile creation/handling (#1225)
f05fdb8 
return values of ShmSetBufferCount evaluated in CSyncMemoryFile::Create function to state failed creation
FlorianReimold pushed a commit that referenced this pull request Oct 27, 2023
@rex-schilasky @FlorianReimold
additional logging added for shm memfile creation/handling (#1225)
9f284f7 
return values of ShmSetBufferCount evaluated in CSyncMemoryFile::Create function to state failed creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KerstinKeller KerstinKeller KerstinKeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rex-schilasky @KerstinKeller