Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fix Race Conditions in CMsgSubscriber #1324

Merged
merged 3 commits into from
Jan 23, 2024
Merged

[Core] Fix Race Conditions in CMsgSubscriber #1324

merged 3 commits into from
Jan 23, 2024

Commits on Jan 22, 2024

  1. [Core] Fix Race Conditions in CMsgSubscriber 

    - Properly implement destructor (in inherited classes)! -> Destroy may not be called in base CMsgSubscriber class as this can lead to stack unwinding (most likely causes an exception in destructor, or leads to already deleted functions of derived class being called when they are already deleted)
- Correct order of RemReceiveCallback and resetting internal pointer
- protect function pointer with mutex.
- Make testcase "harder" to more easily trigger race conditions.
    @KerstinKeller
    KerstinKeller committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c414d52 View commit details
    Browse the repository at this point in the history

  2. Call this->destroy()

    @KerstinKeller
    KerstinKeller committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    184af73 View commit details
    Browse the repository at this point in the history

  3. Clang tidy suggestions.

    @KerstinKeller
    KerstinKeller committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    16b9b28 View commit details
    Browse the repository at this point in the history