[CMake] CROSS_COMPILING builds should be able to locate hdf5. #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianReimold
approved these changes
Jan 31, 2024
FlorianReimold
pushed a commit
that referenced
this pull request
Feb 26, 2024
…) is not properly locatable by CMake. (#1341)
FlorianReimold
pushed a commit
that referenced
this pull request
Feb 27, 2024
…) is not properly locatable by CMake. (#1341)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "hack" was added to enable cross compile builds.
However it's a bad hack, and it's not working for Macos runners, which somehow (some of them) are considered to be cross-compiling?
Alternatively, we could call find_package, and if it fails resort to finding it manually?