Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] CMakePresets.json - enabled BUILD_SAMPLES for cli preset #1496

Conversation

Peguen
Copy link
Contributor

@Peguen Peguen commented Apr 2, 2024

Description

Switched the option "BUILD_SAMPLES" in CMakePresets.json to ON for the CLI preset, as its neccessary for ecal_pb to build. Otherwise mon_tui, mon_cli, sys_core, sys, sys_client, sys_client_core and rec_client_core are missing this dependency.

@DownerCase
Copy link
Contributor

Ah, yeah. The core rework broke that. Technically, for prosperity, a better option would be to decouple the core_pb subdirectory from ECAL_CORE_BUILD_SAMPLES_PROTOBUF into something more like ECAL_CORE_BUILD_PB.

@Peguen Peguen closed this Apr 4, 2024
@Peguen Peguen deleted the hotfix/CMakePresets_build_samples_on branch April 4, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants