[core] Move eCAL::protobuf::CDynamicJSONSubscriber #1605
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -26,13 +26,15 @@ | |||
|
|
|||
| #include <ecal/ecal.h> | |||
There was a problem hiding this comment.
warning: 'ecal/ecal.h' file not found [clang-diagnostic-error]
#include <ecal/ecal.h>
^| class ProtobufDynamicJSONDeserializer | ||
| { | ||
| public: | ||
| std::string Deserialize(const void* buffer_, size_t size_, const SDataTypeInformation& datatype_info_) |
There was a problem hiding this comment.
warning: method 'Deserialize' can be made static [readability-convert-member-functions-to-static]
| std::string Deserialize(const void* buffer_, size_t size_, const SDataTypeInformation& datatype_info_) | |
| static std::string Deserialize(const void* buffer_, size_t size_, const SDataTypeInformation& datatype_info_) |
| m_msg_callback = callback_; | ||
| return true; | ||
| } | ||
| std::string binary_input; |
There was a problem hiding this comment.
warning: variable 'binary_input' is not initialized [cppcoreguidelines-init-variables]
| std::string binary_input; | |
| std::string binary_input = 0; |
| } | ||
| std::string binary_input; | ||
| binary_input.assign(static_cast<const char*>(buffer_), static_cast<size_t>(size_)); | ||
| std::string json_output; |
There was a problem hiding this comment.
warning: variable 'json_output' is not initialized [cppcoreguidelines-init-variables]
| std::string json_output; | |
| std::string json_output = 0; |
| return true; | ||
| } | ||
| private: | ||
| std::shared_ptr<google::protobuf::util::TypeResolver> GetTypeResolver(const SDataTypeInformation& datatype_info_) |
There was a problem hiding this comment.
warning: method 'GetTypeResolver' can be made static [readability-convert-member-functions-to-static]
| std::shared_ptr<google::protobuf::util::TypeResolver> GetTypeResolver(const SDataTypeInformation& datatype_info_) | |
| static std::shared_ptr<google::protobuf::util::TypeResolver> GetTypeResolver(const SDataTypeInformation& datatype_info_) |
| m_topic_type_full = "/" + m_topic_type_full; | ||
| std::shared_ptr<google::protobuf::util::TypeResolver> CreateTypeResolver(const SDataTypeInformation& datatype_info_) | ||
| { | ||
| std::string unqualified_topic_type = GetUnqualifiedTopicType(datatype_info_); |
There was a problem hiding this comment.
warning: variable 'unqualified_topic_type' is not initialized [cppcoreguidelines-init-variables]
| std::string unqualified_topic_type = GetUnqualifiedTopicType(datatype_info_); | |
| std::string unqualified_topic_type = 0 = GetUnqualifiedTopicType(datatype_info_); |
|
|
||
| google::protobuf::FileDescriptorSet proto_desc; | ||
| proto_desc.ParseFromString(topic_desc); | ||
| std::string error_s; |
There was a problem hiding this comment.
warning: variable 'error_s' is not initialized [cppcoreguidelines-init-variables]
| std::string error_s; | |
| std::string error_s = 0; |
|
|
||
| if (resolver == nullptr) | ||
| { | ||
| std::stringstream s; |
There was a problem hiding this comment.
warning: variable 's' is not initialized [cppcoreguidelines-init-variables]
| std::stringstream s; | |
| std::stringstream s = 0; |
|
|
||
| if (m_topic_type.empty()) | ||
| std::string GetQualifiedTopicType(const SDataTypeInformation& data_type_info_) |
There was a problem hiding this comment.
warning: method 'GetQualifiedTopicType' can be made static [readability-convert-member-functions-to-static]
| std::string GetQualifiedTopicType(const SDataTypeInformation& data_type_info_) | |
| static std::string GetQualifiedTopicType(const SDataTypeInformation& data_type_info_) |
| // get topic description | ||
| m_topic_desc = topic_info.descriptor; | ||
| if (m_topic_desc.empty()) | ||
| std::string GetUnqualifiedTopicType(const SDataTypeInformation& data_type_info_) |
There was a problem hiding this comment.
warning: method 'GetUnqualifiedTopicType' can be made static [readability-convert-member-functions-to-static]
| std::string GetUnqualifiedTopicType(const SDataTypeInformation& data_type_info_) | |
| static std::string GetUnqualifiedTopicType(const SDataTypeInformation& data_type_info_) |
based on CDynamicMessageSubscriber
Description
eCAL::protobuf::CDynamicJSON Subscriber is now based on CDynamicMessageSubscriber, which greatly simplifies code.
API break: the message callback API is now changed, which should be fine for eCAL 6.