Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] expmap performance improvement (#1626) #1631

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

rex-schilasky
Copy link
Contributor

  • performance improvement of update_timestamp for large maps (tested with > 25 k entries)
  • monitoring_get_topics sample slightly improved to allow time updates of internal (large) expmaps in case of subsequent readings

* performance improvement of update_timestamp for large maps (tested with > 25 k entries)
* monitoring_get_topics sample slightly improved to allow time updates of internal (large) expmaps in case of subsequent readings
@rex-schilasky rex-schilasky added the cherry-pick-to-NONE Don't cherry-pick these changes label Jun 13, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions


int main(int argc, char **argv)
{
int run(0), runs(1000);
int run(0), runs(10);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]

Suggested change
int run(0), runs(10);
int run(0);
int runs(10);

Copy link
Contributor

@hannemn hannemn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as discussed!

@rex-schilasky rex-schilasky merged commit 7174d7d into support/v5.13 Jun 14, 2024
11 of 12 checks passed
@rex-schilasky rex-schilasky deleted the cherry-pick/ff6b4dd/support/v5.13 branch June 14, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-to-NONE Don't cherry-pick these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants