[core] check-sample-applier-process-id-fix #1676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KerstinKeller
requested changes
Jul 26, 2024
KerstinKeller
approved these changes
Jul 26, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -96,14 +96,44 @@ namespace eCAL | |||
| return true; | |||
| } | |||
|
|
|||
| bool CSampleApplier::IsSameProcess(const Registration::Sample& sample_) | |||
There was a problem hiding this comment.
warning: method 'IsSameProcess' can be made const [readability-make-member-function-const]
Suggested change
| bool CSampleApplier::IsSameProcess(const Registration::Sample& sample_) | |
| bool CSampleApplier::IsSameProcess(const Registration::Sample& sample_) const |
ecal/core/src/registration/ecal_registration_sample_applier.h:56:
- bool IsSameProcess(const Registration::Sample& sample_);
+ bool IsSameProcess(const Registration::Sample& sample_) const;sleep times for registration and unregistration will be fixed later for all tests if active registration/unregistration is working as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check process id for pub/sub, service, client separately in sample applier logic.