Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP #1715 > support/v5.13] [python] add-monitoring-info #1716

Draft
wants to merge 1 commit into
base: support/v5.13
Choose a base branch
from

Conversation

eclipse-ecal-bot
Copy link
Contributor

Cherry-pick failed

Cherry-picked PR #1715 to branch support/v5.13.
The cherry-pick has failed.

The following files have caused conflicts:

lang/python/core/src/ecal_wrap.cxx

Resolving

Please resolve conflicts manually. You can use this PR and branch to your convenience.

git fetch origin
git checkout -b local/cherry-pick/bda08a6/support/v5.13 origin/support/v5.13
git branch -u origin/cherry-pick/bda08a6/support/v5.13
git cherry-pick 5779c0712853277ce445293f76a891e45d353c44..bda08a6c755bd2b4fc65963d32936e571608f107

# Resolve conflicts and use
#     git cherry-pick --continue
# until all conflicts are resolved.

git push -f origin HEAD:cherry-pick/bda08a6/support/v5.13

After resolving all conflicts, rebase-merge this PR.

@KerstinKeller KerstinKeller force-pushed the cherry-pick/bda08a6/support/v5.13 branch from 994074e to 3ada714 Compare October 2, 2024 12:23
Copy link
Contributor

@KerstinKeller KerstinKeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, these are API changes. Do we need / want it for 5.13?
Do we make a 5.14 instead? What should be in it?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions


// collect client infos
{
PyObject* clientList = PyList_New(0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: variable 'clientList' is not initialized [cppcoreguidelines-init-variables]

Suggested change
PyObject* clientList = PyList_New(0);
PyObject* clientList = nullptr = PyList_New(0);


for (int i = 0; i < monitoring.clients().size(); ++i)
{
PyObject* clientDict = PyDict_New();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: variable 'clientDict' is not initialized [cppcoreguidelines-init-variables]

Suggested change
PyObject* clientDict = PyDict_New();
PyObject* clientDict = nullptr = PyDict_New();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants