[python] Call_method in service now allows threads. #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peguen
added
cherry-pick-to-support/v5.12
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -813,7 +813,9 @@ PyObject* client_call_method(PyObject* /*self*/, PyObject* args) // (client_ha | |||
| PyArg_ParseTuple(args, "nsy#i", &client_handle, &method_name, &request, &request_len, &timeout); | |||
|
|
|||
| bool called_method{ false }; | |||
| called_method = client_call_method(client_handle, method_name, request, (int)request_len, timeout); | |||
| Py_BEGIN_ALLOW_THREADS | |||
| called_method = client_call_method(client_handle, method_name, request, (int)request_len, timeout); | |||
There was a problem hiding this comment.
warning: variable 'called_method' is not initialized [cppcoreguidelines-init-variables]
Suggested change
| called_method = client_call_method(client_handle, method_name, request, (int)request_len, timeout); | |
| called_method = 0 = client_call_method(client_handle, method_name, request, (int)request_len, timeout); |
KerstinKeller
approved these changes
Oct 2, 2024
KerstinKeller
pushed a commit
that referenced
this pull request
Oct 4, 2024
) (#1762) If service and client are located in the same process, the previous implementation of `call_method` caused deadlocks due to the GIL. Co-authored-by: Peguen <[email protected]>
KerstinKeller
pushed a commit
that referenced
this pull request
Oct 4, 2024
) (#1761) If service and client are located in the same process, the previous implementation of `call_method` caused deadlocks due to the GIL. Co-authored-by: Peguen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you used a service client and server in the same process (like described in this issue: #1755), the application locks. With this fix, it does not lock anymore and function as expected.