Fix cmake to defein ROS_DISTRO and HUMBLE #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to fix #70
The main problem of that issue is that
ROS_DISTRO
was incorrectly defined as string not value (like 1 2 3), so many lines of code was actually not compiled.Then the macro is defined correctly and then some code becomes redundant, so both
rmw_ecal_dynamic_cpp/src/rmw/features.cpp
andrmw_ecal_proto_cpp/src/rmw/features.cpp
are deleted, shared code ofrmw_ecal_shared_cpp/src/features.cpp
is used instead.After this PR, #70 is fixed but
rmw_ecal_proto_cpp
still does not run because of another issue, which will be reported later.