Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake to defein ROS_DISTRO and HUMBLE #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felixf4xu
Copy link

this is to fix #70

The main problem of that issue is that ROS_DISTRO was incorrectly defined as string not value (like 1 2 3), so many lines of code was actually not compiled.

Then the macro is defined correctly and then some code becomes redundant, so both rmw_ecal_dynamic_cpp/src/rmw/features.cpp and rmw_ecal_proto_cpp/src/rmw/features.cpp are deleted, shared code of rmw_ecal_shared_cpp/src/features.cpp is used instead.

After this PR, #70 is fixed but rmw_ecal_proto_cpp still does not run because of another issue, which will be reported later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to resolve symbol
1 participant