Solved some TODOs

eclipse-ecal · Feb 23, 2024 · bc8391b · bc8391b
1 parent 5e72a8a
commit bc8391b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 16 deletions.
diff --git a/udpcap/CMakeLists.txt b/udpcap/CMakeLists.txt
@@ -71,7 +71,7 @@ generate_export_header(${PROJECT_NAME}
 add_library (udpcap::${PROJECT_NAME} ALIAS ${PROJECT_NAME})
 
 target_link_libraries(${PROJECT_NAME}
-    PRIVATE #TODO: This used to be private
+    PRIVATE
         npcap::npcap
         pcapplusplus::pcapplusplus
         $<$<BOOL:${WIN32}>:ws2_32>
@@ -129,8 +129,10 @@ endif()
 
 ##################################
 
-include(sourcetree.cmake)
-create_source_tree(${includes} ${sources})
+source_group(TREE "${CMAKE_CURRENT_SOURCE_DIR}" FILES 
+    ${includes}
+    ${sources}
+)
 
 ################################################################################
 ### Installation rules

diff --git a/udpcap/sourcetree.cmake b/udpcap/sourcetree.cmake
diff --git a/udpcap/src/ip_reassembly.h b/udpcap/src/ip_reassembly.h
@@ -121,7 +121,6 @@ namespace Udpcap
 	  * - If the reassembled packet isn't ready then NULL is returned
 	  */
 	pcpp::Packet* processPacket(pcpp::RawPacket* fragment, pcpp::IPReassembly::ReassemblyStatus& status, pcpp::ProtocolType parse_until = pcpp::UnknownProtocol, pcpp::OsiModelLayer parse_until_layer = pcpp::OsiModelLayerUnknown);
-	// TODO: Implement rawPacket function
 
 	/**
 	  * Get the maximum capacity as determined in the c'tor