refactor: incorrect paramaters order in dataplane logs regarding DataFlow Id #4833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmg13
changed the title
bmg13
changed the title
|
Tests? |
Since this was a simple log order change, assumed no need of tests, but would avoid happening again, will add, thank you! |
jimmarino
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Fixes the order of the parameters in three logs in the DataPlane to ensure consistent reading of DataSource, DataDestination and DataFlowId fields in a Transfer Process.
Why it does that
To keep logic order in log reading.
Linked Issue(s)
Closes #4804