feat: implement DID management API #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
requested review from
bscholtes1A,
jimmarino,
ndr-brt and
wolf4ood
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...c/main/java/org/eclipse/edc/identityhub/api/didmanagement/v1/DidManagementApiController.java
Fixed
Show fixed
Hide fixed
...c/main/java/org/eclipse/edc/identityhub/api/didmanagement/v1/DidManagementApiController.java
Fixed
Show fixed
Hide fixed
...c/main/java/org/eclipse/edc/identityhub/api/didmanagement/v1/DidManagementApiController.java
Fixed
Show fixed
Hide fixed
...c/main/java/org/eclipse/edc/identityhub/api/didmanagement/v1/DidManagementApiController.java
Fixed
Show fixed
Hide fixed
paullatzelsperger
force-pushed
the
feat/implement_did_management_api
branch
from
bd23c1f to
74f0e19
Compare
paullatzelsperger
force-pushed
the
feat/implement_did_management_api
branch
from
74f0e19 to
c27b329
Compare
ndr-brt
reviewed
Dec 20, 2023
...-hub-did/src/main/java/org/eclipse/edc/identityhub/did/DidDocumentPublisherRegistryImpl.java
Outdated
Show resolved
Hide resolved
core/identity-hub-did/src/main/java/org/eclipse/edc/identityhub/did/DidDocumentServiceImpl.java
Show resolved
Hide resolved
...c/main/java/org/eclipse/edc/identityhub/api/didmanagement/v1/DidManagementApiController.java
Show resolved
Hide resolved
...c/main/java/org/eclipse/edc/identityhub/api/didmanagement/v1/DidManagementApiController.java
Show resolved
Hide resolved
jimmarino
approved these changes
Dec 20, 2023
...dentity-hub-did-spi/src/main/java/org/eclipse/edc/identithub/did/spi/DidDocumentService.java
Outdated
Show resolved
Hide resolved
…hub/did/spi/DidDocumentService.java Co-authored-by: Jim Marino <[email protected]>
wolf4ood
approved these changes
Dec 20, 2023
ndr-brt
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds a CRUD management API for Decentralized Identifiers (DID). More specifically, it adds:
DidManagementApithat contains swagger annotationsDidManagementApiControllerthat implements the REST interfaceDidDocumentServiceImpl, that acts as aggregate service and creates the transaction boundaryDidRequestValidator, that validates the structure of aDidDocumentWhy it does that
For managing DID documents
Further notes
DidResourceobjects, the Management API only exposesDidDocumentobjects (which are a part ofDidResources) and provides specific endpoints for "actions", such aspublish. This is done because those actions are synchronous, which means there is no state machine that could pick up e.g. a state change, so they need to be executed explicitly.POST /v1/dids/{did}/publish. however, since (web) DIDs can contain port definitions, which - if properly URL-encoded - are not discernible from the normal segment separator":"anymore.Linked Issue(s)
Closes #190
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.