chore: re-use existing DataModelVersion #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
chore/reuse_existing_datamodel_enum
branch
from
02cfb36 to
2636034
Compare
wolf4ood
approved these changes
Feb 6, 2025
paullatzelsperger
force-pushed
the
chore/reuse_existing_datamodel_enum
branch
2 times, most recently
from
3430b0f to
03a54f2
Compare
paullatzelsperger
force-pushed
the
chore/reuse_existing_datamodel_enum
branch
from
03a54f2 to
8361500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
this PR makes use of the existing
DataModelVersioninstead of declaring a newDataModelTypeWhy it does that
avoid duplication
Further notes
had to fix a test, otherwise the CI would fail sometimes.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.