Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first impl of DCP credential request API #566

Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Feb 11, 2025

What this PR changes/adds

First impl of DCP credential request API:

  • Introduced DcpIssuerSelfIssuedTokenVerifier for validating the SI token from the participant
  • Introduced DcpIssuerService for running the attestation pipeline and validation after SI token verification
  • Introduced CredentialRuleDefinitionEvaluator for evaluating a list of CredentialRuleDefinition in an IssuanceContext
  • Split issuance-credentials into two extensions issuerservice-issuance-attestations and issuerservice-issuance-rules for supported attestations and rules
  • Added a DcpIssuanceApiEndToEndTest for testing the credentials request API
  • Introduced a property edc.issuer.id for configuring the issuer DID (might be temporary)

Why it does that

dcp credential requests API support

Further notes

Left out in this PR:

  • Rule and Attestation Validators
  • Mapping validation (we might validate the mapping upon receiving a request)
  • Presentation Query on Issuance
  • ExternalApprovalPredicate (if the issuance process should be automatically approved)
  • In DcpIssuanceApiEndToEndTest the attestation source is mocked.

Who will sponsor this feature?

Please @-mention the committer that will sponsor your feature.

Linked Issue(s)

Closes #553

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood self-assigned this Feb 11, 2025
@wolf4ood wolf4ood added the enhancement New feature or request label Feb 11, 2025
@wolf4ood wolf4ood force-pushed the feat/553_dcp_issuance_credentials_api branch 9 times, most recently from 85d894f to 45ee609 Compare February 12, 2025 13:42
@wolf4ood wolf4ood marked this pull request as ready for review February 12, 2025 13:48
@wolf4ood wolf4ood requested a review from jimmarino February 12, 2025 13:48
@wolf4ood wolf4ood force-pushed the feat/553_dcp_issuance_credentials_api branch from 45ee609 to ad2bd24 Compare February 12, 2025 13:55
@wolf4ood wolf4ood force-pushed the feat/553_dcp_issuance_credentials_api branch from ad2bd24 to 270e9a4 Compare February 12, 2025 14:05
@wolf4ood wolf4ood merged commit fb6fc8e into eclipse-edc:main Feb 12, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DCP issuer v1.0 credentials endpoint
3 participants