feat: add Credential Request endpoints (IdentityApi) #590
Conversation
paullatzelsperger
force-pushed
the
add_credentialrequest_endpoints
branch
from
8f5c79a to
88bd15b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| content = @Content(array = @ArraySchema(schema = @Schema(implementation = ApiErrorDetail.class)), mediaType = "application/json")) | ||
| } | ||
| ) | ||
| HolderCredentialRequestDto getCredentialRequest(String participantContextId, String issuanceProcessId, SecurityContext securityContext); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| @@ -126,8 +126,7 @@ | |||
| return this; | |||
| } | |||
|
|
|||
| @Override | |||
| public IssuerCredentialIssuanceProcess build() { | |||
| public IssuanceProcess build() { | |||
Check notice
Code scanning / CodeQL
Missing Override annotation Note
| @@ -124,6 +126,11 @@ | |||
| return revocationService; | |||
| } | |||
|
|
|||
| @Provider(isDefault = true) | |||
| public CredentialRequestService createDefaultCredentialRequestService(ServiceExtensionContext context) { | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
| * @param typesAndFormats A map containing credential-type - credential-format entries | ||
| * @return A ServiceResult containing the issuer-assigned process ID, or a failure otherwise. | ||
| */ | ||
| ServiceResult<String> initiateRequest(String issuerDid, String requestId, Map<String, String> typesAndFormats); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * @param typesAndFormats A map containing credential-type - credential-format entries | ||
| * @return A ServiceResult containing the issuer-assigned process ID, or a failure otherwise. | ||
| */ | ||
| ServiceResult<String> initiateRequest(String issuerDid, String requestId, Map<String, String> typesAndFormats); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * @param typesAndFormats A map containing credential-type - credential-format entries | ||
| * @return A ServiceResult containing the issuer-assigned process ID, or a failure otherwise. | ||
| */ | ||
| ServiceResult<String> initiateRequest(String issuerDid, String requestId, Map<String, String> typesAndFormats); |
Check notice
Code scanning / CodeQL
Useless parameter Note
What this PR changes/adds
this PR adds two endpoints to the IdentityApi, specifically the VerifiableCredentials API to initiate credential requests, and to obtain
credential requests.
Why it does that
to be able to initiate credential requests and to get them later
Further notes
IssuerCredentialIssuanceProcess->IssuanceProcess), because on the holder side we'll call it "CredentialRequest", on the issuer side we'll call it "IssuanceProcess"Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #586
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.