Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Dependency Correction on Cloud Transfer Sample #176

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

Miyagi61
Copy link
Contributor

@Miyagi61 Miyagi61 commented Dec 8, 2023

What this PR changes/adds

This PR adds dependencies on the "transfer/transfer-05-file-transfer-cloud/cloud-transfer-consumer/build.gradle.kts" and "transfer/transfer-05-file-transfer-cloud/transfer-file-cloud/build.gradle.kts"

Why it does that

This dependencies are added because there was an error when trying to run the jar file.

Linked Discussion

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'

@ndr-brt ndr-brt added the bug Something isn't working label Dec 11, 2023
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please sign the ECA so we can merge this
it was signed and the view not updated, LGTM

@ndr-brt ndr-brt merged commit d0c0c47 into eclipse-edc:main Dec 11, 2023
8 of 9 checks passed
@Miyagi61
Copy link
Contributor Author

@ndr-brt could you take a look at the other part of my correction on the linked discussion. Should I open another PR for the docs correction I suggested, although it's incomplete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants