Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compile errors after EDC token refactor #105

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Briefly describe WHAT your pr changes, which features it adds/modifies.

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

@paullatzelsperger paullatzelsperger added the bug Something isn't working label Jan 14, 2024
Copy link
Contributor

github-actions bot commented Jan 14, 2024

Test Results

59 tests  +25   59 ✅ +25   8s ⏱️ +4s
10 suites + 4    0 💤 ± 0 
10 files   + 4    0 ❌ ± 0 

Results for commit 17d03cf. ± Comparison against base commit 2a7acbd.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2a7acbd) 63.71% compared to head (17d03cf) 63.52%.

Files Patch % Lines
.../edc/vault/gcp/GcpSecretManagerVaultExtension.java 66.66% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   63.71%   63.52%   -0.19%     
==========================================
  Files          24       24              
  Lines         598      595       -3     
  Branches       30       30              
==========================================
- Hits          381      378       -3     
  Misses        205      205              
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -37,7 +34,7 @@
/**
* ServiceExtension instantiating and registering Vault object.
*/
@Provides({ Vault.class, PrivateKeyResolver.class, CertificateResolver.class })
@Provides({ Vault.class })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed

@ndr-brt ndr-brt merged commit 5a573ef into main Jan 15, 2024
23 checks passed
@ndr-brt ndr-brt deleted the fix/compile_errors branch January 15, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants