Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: BigQuery support #137

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Conversation

man8pr
Copy link
Contributor

@man8pr man8pr commented Mar 6, 2024

Decision about BigQuery support for EDC.

What this PR changes/adds

Created the decision-records folder under docs and the record for BQ.

First description of basic BigQuery extensions.
@man8pr man8pr added the documentation Improvements or additions to documentation label Mar 6, 2024
@man8pr man8pr requested a review from paullatzelsperger March 6, 2024 07:59

Add the BigQuery extensions to enable the transfer of data to and from BigQuery tables.

### Extensions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: most of our other decision records have the following structure:

  • Decision: states what has been decided. you already have that here.
  • Rationale: why and how that decision was reached, i.e. paraphrasing "because we want to support a wider ranger of GCP services, namele BigQuery"
  • Approach: how the decision is put into action. Basically, just put your "Extensions", "Data Source", "Data Sink", "Notes", and "Future Development" sections under a the "Approach" heading.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@man8pr man8pr requested a review from paullatzelsperger March 7, 2024 07:04
@ndr-brt ndr-brt merged commit 9583567 into eclipse-edc:main Mar 7, 2024
14 checks passed
@man8pr man8pr deleted the doc/bigquery_extension branch March 8, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants