-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: BigQuery support #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First description of basic BigQuery extensions.
ndr-brt
reviewed
Mar 6, 2024
paullatzelsperger
approved these changes
Mar 6, 2024
|
||
Add the BigQuery extensions to enable the transfer of data to and from BigQuery tables. | ||
|
||
### Extensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: most of our other decision records have the following structure:
- Decision: states what has been decided. you already have that here.
- Rationale: why and how that decision was reached, i.e. paraphrasing "because we want to support a wider ranger of GCP services, namele BigQuery"
- Approach: how the decision is put into action. Basically, just put your "Extensions", "Data Source", "Data Sink", "Notes", and "Future Development" sections under a the "Approach" heading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
…ationale, approach
paullatzelsperger
approved these changes
Mar 7, 2024
ndr-brt
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decision about BigQuery support for EDC.
What this PR changes/adds
Created the decision-records folder under docs and the record for BQ.