Bug 544202 - Fix CacheKey.protectedForeignKeys update #369
Conversation
|
Issue tracker reference: |
1 similar comment
|
Issue tracker reference: |
| * | ||
| * SPDX-License-Identifier: EPL-2.0 OR BSD-3-Clause | ||
| ******************************************************************************/ | ||
|
|
There was a problem hiding this comment.
can you follow the convention used in other files wrt formatting of license header? I do not think this is going to pass the copyright check - verify by running mvn -Pcoding-standards glassfish-copyright-mave-plugin:check or mvn -Pcoding-standards glassfish-copyright-mave-plugin:copyright (the latter will show wrong files but won't fail the build in case of errors) - note that the check may take up to 2hours to finish
There was a problem hiding this comment.
Hello @lukasj, thank you for your attention, I fixed the copyright as you suggested.
I ran:
mvn -X -Pcoding-standards glassfish-copyright:copyright -pl foundation/org.eclipse.persistence.core
And can confirm it ends with a BUILD SUCCESS and no reported errors.
I rebased master on my branch in order to be up to date
There was a problem hiding this comment.
Updated PR's description. Everything was already in bugzilla + test case but it's better to sum up here for future reference
Signed-off-by: Alexandre Jacob <[email protected]>
Problem
There is an issue with 2nd level cache and
@NonCacheablewhere a relationship could be not refreshed correctly.To reproduce this problem you need:
eclipselink.cache.shared.defaultfalse)EntityAconfigured for 2nd level caching (eclipselink.cache.shared.EntityAtrue)EntityBnot configured for 2nd level (default)EntityAneeds to have a relation (tested with@ManyToOne) withEntityB, this relation needs to be annotated with@Noncacheable.If you fetch an instance of
EntityAa1linked with an instance ofEntityBb1, and then you updatea1to be linked withb2, foreign key cache will not be updated correctly anda1will remain linked withb1.The first attempt to re-load
a1will bring correctlyb2but all subsequent calls will bring backb1.Solution
Fixed this problem by updating foreign key values when CacheKey is in
CACHE_KEY_INVALIDstate.