Support grizzly-memcached's monitoring features using Grizzly JMX #14
+1,534
−289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Grizzly JMX"(eclipse-ee4j#13) + (Trivial) Fixed several log messages and line alignment. + (Trivial) Updated pom's library version.
…izzly JMX"(eclipse-ee4j#13) + removed unnecessary comments(local test codes).
|
@arjantijms |
carryel
requested review from
stuartwdouglas,
mbarbero,
waynebeaton,
chrisguindon,
netomi,
mrybczyn,
m0mus,
edbratt,
jGauravGupta,
anajosep and
pnicolucci
|
If anyone has the time, I would greatly appreciate it if you could leave a review or approve this PR. I would like to release this version, but it needs review/approval for merging. This function has been tested in test cases and locally, and a release is required for application to the production environment. |
…izzly JMX"(eclipse-ee4j#13) + added several ManagedOperation
…izzly JMX"(eclipse-ee4j#13) + fixed testcase's failure.
|
Sorry, this one fell of the radar. I will review today. Thanks for your patience! |
…izzly JMX"(eclipse-ee4j#13) + For errors that occur when enabling/disabling JMX, only logs are left and the errors are ignored.
…izzly JMX"(eclipse-ee4j#13) + Added stats using JMX's CompositeData.
…izzly JMX"(eclipse-ee4j#13) + Added stats(Keyed object which is generally related to network connection managed in the basic object pool).
- Changed the minimum java version to 11 or higher. - Replaced the use of NullaryFunction, which has been removed since Grizzly framework 4.0.1, with Supplier (related issue eclipse-ee4j/grizzly#2179). - Updated the minor version of grizzly-memcached (1.3.x -> 1.4.x).
…izzly JMX"(eclipse-ee4j#13) + Fixed an issue where the previous pool was monitored instead of the newly created pool when the pool was dynamically destroyed and recreated. + Remove unused(duplicated) mbean attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13