fix #1645 adding until 12 indent levels #1747
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Santos Izaguirre <[email protected]>
laeubi
reviewed
Jul 20, 2024
| * | ||
| * Doesn't have to be final, but it helps the JVM. | ||
| * | ||
| * @author Kohsuke Kawaguchi | ||
| */ | ||
| public final class IndentingUTF8XmlOutput extends UTF8XmlOutput { | ||
|
|
||
| private static final int MAX_DEPTH = 12; |
There was a problem hiding this comment.
Suggested change
| private static final int MAX_DEPTH = 12; | |
| private static final int MAX_DEPTH = Integer.getInteger("jaxb.ri.max_depth", 12); |
|
This will fix #1645 is there any reason to not proceed on this? |
|
Hi any news on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lukasj
It's not the best solution, but fixes 8 indentation levels, adding until 12.
Please rate this PR if you think it is appropriate to solve the issue.
Regards,
Antonio.