Automatically add Protobuf output source directories to classpath #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdneo
requested review from
rgrunber,
testforstephen,
CsCherrYY,
snjeza and
fbricon
snjeza
reviewed
Aug 16, 2022
...eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/GradleProjectImporter.java
Show resolved
Hide resolved
snjeza
approved these changes
Aug 17, 2022
2 tasks
|
I just append a new commit to make the default value of protobuf support false at server side, which means only the client explicitly set that preference to true will the server side do the enhancement. |
CsCherrYY
approved these changes
Aug 18, 2022
rgrunber
requested changes
Aug 18, 2022
...eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/GradleProjectImporter.java
Outdated
Show resolved
Hide resolved
...eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/GradleProjectImporter.java
Outdated
Show resolved
Hide resolved
...eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/GradleProjectImporter.java
Outdated
Show resolved
Hide resolved
rgrunber
changed the title
rgrunber
approved these changes
Aug 19, 2022
|
Feel free to squash & merge when ready. If you use the top commit, don't forget to fix the typo, |
A Gradle init script is added as a patch to automatically add Protobuf output source directories to classpath. The script works for Gradle 'com.google.protobuf' plugin 0.8.4 or higher. The init script will be extracted to a cache folder. As a side effect, the Protobuf output source directories will be created beforehand, due to an issue of Buildship. See: eclipse-buildship/buildship#1196. Signed-off-by: sheche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Gradle init script is added as a patch to automatically add Protobuf
output source directories to clsspath. The script works for Gradle
'com.google.protobuf' plugin 0.8.4 or higher.
The init script will be extracted as a sibling file of the bundle jars.
As a side effect, the Protobuf output source directories will be created
beforehand, due to an issue of Buildship.
See: eclipse-buildship/buildship#1196.
Related issues
This should mitigate some complains about protobuf support:
I also raised a PR at the protobuf plugin repo to support Eclipse classpath: google/protobuf-gradle-plugin#596.
How to test this PR
retrofit-converters/protobuf's .classpath file../gradlew generateTestProto, those type not found errors disappear.requires: redhat-developer/vscode-java#2629
Signed-off-by: sheche [email protected]