Improve JDTUtils.resolveCompilationUnit #3314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snjeza
requested review from
fbricon,
mickaelistria,
rgrunber,
jdneo and
testforstephen
rgrunber
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Before (javac)
[Trace - 14:36:46] Received response 'textDocument/hover - (43)' in 9404ms.
[Trace - 14:37:23] Received response 'textDocument/hover - (48)' in 6120ms.
[Trace - 14:37:47] Received response 'textDocument/hover - (51)' in 6583ms.
[Trace - 14:39:08] Received response 'textDocument/hover - (53)' in 6115ms.
[Trace - 14:39:45] Received response 'textDocument/hover - (55)' in 6162ms.
After (javac)
[Trace - 14:45:42] Received response 'textDocument/hover - (36)' in 320ms.
[Trace - 14:45:48] Received response 'textDocument/hover - (38)' in 638ms.
[Trace - 14:45:54] Received response 'textDocument/hover - (40)' in 122ms.
[Trace - 14:45:58] Received response 'textDocument/hover - (42)' in 139ms.
Yeah.. I guess that's an improvement 😂
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JDTUtils.java
Outdated
Show resolved
Hide resolved
|
@rgrunber I have updated the PR. |
rgrunber
reviewed
Oct 31, 2024
Signed-off-by: Snjezana Peco <[email protected]>
|
@testforstephen this change might have a good impact on the perf issue you used to see regarding test codelens computation. |
Great improvement. Good to know it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3313