Guard against snippet position groups with undefined (-1) offsets. #3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A linked correction proposal group may refer to positions whose offset cannot be resolved - Add testcase Signed-off-by: Roland Grunberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hopehadfield , if you're interested, it'd be good to know if you agree that this would have always been an issue (I did notice the exact same quick-fix has the exact same problem in Eclipse). I could have sworn there was a case where we discussed how to translate to relative offsets within the edit, but can't really see where we do that. Maybe when we considered splitting up the edits so it wasn't just one giant thing ?
Either way, the issue here is that we want to sync up 2 or more positions inside the actual edit, but we can't because the edit hasn't been applied so there wouldn't be an offset in the sources.